Skip to content

fix some links, add error rules, remove footer#566

Merged
jukent merged 11 commits intoProjectPythia:mainfrom
jukent:linkerrorrules
Mar 2, 2026
Merged

fix some links, add error rules, remove footer#566
jukent merged 11 commits intoProjectPythia:mainfrom
jukent:linkerrorrules

Conversation

@jukent
Copy link
Contributor

@jukent jukent commented Feb 25, 2026

Closes #565

  • Footer specification no longer needed as site parts extension is now supported in MyST
  • Fix links that I can
  • Excluding links that are not expected to fail

Could not track down

posts/2025/new-cookbooks.md
  - Link for "" did not resolve.

And I'm not sure if the unexpected figure content of type output found in legend node in metrics.md are a quirk of how the pipeline works (but doesn't pass strict build) or if there is a larger issue. May have to diagnose in a different PR.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: db5be63
✅ Deployment Preview URL: https://projectpythia.github.io/_preview/566

@jukent
Copy link
Contributor Author

jukent commented Feb 26, 2026

Our nightly build failure included this as to metrics.md: unexpected figure content of type output found in legend node

But the PR was having trouble accessing the keys altogether?
ValueError: Unable to load PEM file. See https://cryptography.io/en/latest/faq/#why-can-t-i-import-my-pem-file for more details. MalformedFraming

Our metrics page says, "Last Updated: 2026-02-24 02:46:24.757143" with our last "successful" nightly build being 2026-02-23 at 7:45PM Mountain time. So it is the --strict call is messing with our metrics collection? Unlikely, probably due to nightly-build failing due to the broken links.

@jukent
Copy link
Contributor Author

jukent commented Feb 26, 2026

Not ideal, but PRs from forks will always fail to build metrics due to GitHub secrets/token handling. I tried 'myst build --execute --html --strict --exclude metrics.md' but exclude is not a valid MyST flag. Not sure turning off --strict is smart for PRs either, but it might be the only workaround available right now.

Any advice @agoose77 ? Can I somehow add "unexpected figure content of type output found in legend node" to the error-rules exclusions in the myst.yml file?

E: Seems the key for the above error is container-children-valid. It was harder to run myst --debug build because I had to track down our private key and key id that are hidden in GH secrets. But I got it.

@jukent jukent marked this pull request as ready for review February 26, 2026 19:52
@jukent jukent requested review from a team as code owners February 26, 2026 19:52
@jukent jukent requested review from brian-rose, clyne, dcamron and ktyle and removed request for a team February 26, 2026 19:52
@jukent jukent requested a review from erogluorhan March 1, 2026 17:17
Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for looking into this! Now that you seem to have figured out PRs from forks, this seems good to me.

@jukent jukent merged commit 4f9754b into ProjectPythia:main Mar 2, 2026
3 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 2, 2026
@jukent
Copy link
Contributor Author

jukent commented Mar 2, 2026

I think ideally I'd like to change the pull request build test to something like `build_command: 'myst build --execute --html --strict --exclude metrics.md' so we still have strict testing for everything except an action that will always fail when run from a fork. If this is possible @agoose77 let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Builds are failing due to link problems

3 participants